Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExperimentClient.observe support single value #1063

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

bouthilx
Copy link
Member

Why:

Formatting results as dict(name, type, value) is cumbersome and the most common use case is observing a single result which is the objective. This use case should be simplified.

How:

Support client.observe(trial, value, name) and still support client.observe(trial, results).

@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Jan 10, 2023
Why:

Formatting results as dict(name, type, value) is cumbersome and the most
common use case is observing a single result which is the objective.
This use case should be simplified.

How:

Support `client.observe(trial, value, name)` and still support
`client.observe(trial, results)`.
@bouthilx bouthilx force-pushed the hotfix/fix_checkpoint_tutorial branch from b7f8d92 to 89a37b0 Compare January 11, 2023 17:45
@Delaunay Delaunay merged commit c2980e2 into Epistimio:develop Jan 11, 2023
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants