Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list instead of array #1050

Merged
merged 25 commits into from
Jan 11, 2023
Merged

Conversation

bouthilx
Copy link
Member

Numpy does not seam to support anymore non homogeneous arrays (for shapes at least). We don't need an array, so we should rather use lists.

Numpy does not seam to support anymore non homogeneous arrays (for
shapes at least). We don't need an array, so we should rather use lists.
@bouthilx bouthilx requested a review from Delaunay December 20, 2022 13:44
@bouthilx bouthilx added the ci label Dec 20, 2022
tests/unittests/algo/test_tpe.py Outdated Show resolved Hide resolved
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@Delaunay
Copy link
Collaborator

Delaunay commented Jan 5, 2023

The issue here is dependencies using the deprecated np.object.
orion phased it out recently but dependencies are still using it and the object was removed in the latest numpy release
we will have to downgrade numpy on our side to keep the compatibility

The dependency is pymoo
/~https://github.com/Epistimio/orion/actions/runs/3741043328/jobs/6352133656#step:5:26037

pymoo actually updated on their latest version /~https://github.com/anyoptimization/pymoo/blob/4dae90a8e1c10d0f858b391903d39b0ff365fd59/examples/algorithms/moo/nsga2/nsga2_custom.py#L35

@Delaunay Delaunay force-pushed the hotfix/numpy_array_fix branch from 926c5eb to 3f1576e Compare January 9, 2023 17:53
@Delaunay Delaunay force-pushed the hotfix/numpy_array_fix branch from 82120ea to f5a214a Compare January 9, 2023 18:26
@Delaunay Delaunay force-pushed the hotfix/numpy_array_fix branch from 640e25d to ba00073 Compare January 9, 2023 20:38
@Delaunay Delaunay merged commit 9c81a61 into Epistimio:develop Jan 11, 2023
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants