Support group length tags in dictionary, update dictionary-std documentation and implementation #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- (BREAK) add TagRange::GroupLength - Adjust the rest of the code accordingly - Add static dictionary entry for generic group length attribute - return it via get when appropriate - Add respective test
- change DICT to become a Lazy<StandardDictionaryRegistry> - add inline hint to registry() - document things a bit better
Enet4
added
breaking change
- Command Group Length (0000,0000) and File Meta Information Group Length_ (0002,0000) still have their own single tag records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to the dictionary API and to the implementation of
dictionary-std.Summary
TagRangenow describes group length tags (gggg,0000) in a separate variant, so that applications such as dicom-dump know its alias when it occurs.TagRangeand its methods.once_cellinstead oflazy_static.OnceCellis already part ofstdas of Rust 1.70.0, andLazyCellmight become available eventually, making this a smooth transition in the future.dictionary-stditems.