Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

rentbw additional changes #422

Merged
merged 8 commits into from
Dec 19, 2019
Merged

rentbw additional changes #422

merged 8 commits into from
Dec 19, 2019

Conversation

arhag
Copy link
Contributor

@arhag arhag commented Dec 18, 2019

Change Description

Changes:

  • More cleanup
  • Fix name of configrentbw action wrapper type.
  • Add defaults for rent_days (30 days), decay_secs (1 day), and exponent (2.0).
  • Also added defaults for min_rent_price and target_price. Assuming a core symbol of symbol("SYS", 4), the default for min_rent_price would be 0.0100 SYS and the default for target_price would be 100,000,000.0000 SYS. (While included in this PR, this change was later removed from PR rentbw #397.)
  • Include calculated rental fee in error message when max_payment is too low so that the user has an idea of how much the max_payment needs to be under current market conditions.
  • Change rounding used in fee calculation to not give an advantage to very small rentals under particular situations (but still under the condition of utilization >= adjusted_utilization).

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

…dvantage to very small rentals under particular situations (but still under the condition of utilization >= adjusted_utilization)

Also add calculated fee to the error message when it exceeds 
max_payment.
@arhag arhag requested a review from larryk85 December 18, 2019 23:03
@arhag arhag merged commit ce1d510 into resource31 Dec 19, 2019
@arhag arhag deleted the resource31-more-changes branch December 19, 2019 01:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants