Fixture/some improvements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mberacochea
reviewed
Dec 17, 2024
There was a problem hiding this comment.
The output name sounds a bit odd to be. This is the one that contains the marker genes that weren't found in the bins, right?
Maybe "missing_marker_genes.csv"?
| write_table(b.state, result_table) | ||
|
|
||
| if b.state["marker_set"]["quality"] != "good": | ||
| logging.debug("Quality is not good") |
There was a problem hiding this comment.
Is there a definition of "good" somwhere?
There was a problem hiding this comment.
kind of...
Line 23 in 698c32d
There was a problem hiding this comment.
I would add that to the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bad_quality.csvandno_placement_marker_genes.txtfor folder mode. Related to Folder mode missed results for some bins #43. I answered there what is going on.