FIX missing state in openid connect #29788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentPoinsaut
force-pushed
the
fix-missing-state-in-openid-connect
branch
from
f53a8dc to
9bb5a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX missing state in OpenId Connect
If two users log in at the same time via OpenID Connect, one may recover the session from the other and vice versa. This is due to the fact that there is no discrimination that determines who made the request for authentication.
The usual discriminant is normally a parameter passed to the first call and verified during the response that is called
state. It is also recommended here: https://openid.net/specs/openid-connect-core-1-0.html-rfc.section.3.1.2.1