Incoherence in loan payment management

[thomas-Ngr]

Bug

On module loan (htdocs/loan/list.php) , deleting a payment causes issues :

1. The bank line still exists after deleting the payment. Should it still exist, or should it be deleted with the payment loan ?
2. The bank line is not linked to the payment anymore, but is still linked to the loan. As a consequence :
   • on the loan screen, the payment is not shown
   • but, if the line is reconciliated, the loan can't be deleted. Moreover, no error is displayed (see PR FIX : display error when loan can't be deleted #32338). The user has no clue on what is going on. Even if there was an error, the user can't navigate from the loan to the faulty bank line, so they can't fix the problem.

Dolibarr Version

18.0, develop

Environment PHP

any

Environment Database

any

Steps to reproduce the behavior and expected behavior

To reproduce

• create a loan
• create a payment for this loan.
  • Observe that this has created a bank line. (expected behavior)
• delete the payment
• navigate to the bank line.
  • Observe that it is still linked to the loan
• navigate to the loan.
  • Observe that there is no payment shown, so the user can't navigate to the related bank line.
• Try to delete it.
  • Observe that it can't be deleted.

Expected behavior

I think that, when we delete a payment loan, the related bank line should be also deleted. And if the bank line is reconciliated, one should not be able to delete the payment.

Attached files

No response

[thomas-Ngr]

@aspangaro do you have a suggestion before I start implementing it ?

[aspangaro]

Hi @thomas-Ngr

I confirm this problem also in v21.

Thanks for the report, I propose the fix #32346 using the delete() function of the AccountLine class