Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Use a single version of dmd, from path #15

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Feb 10, 2021

The usage of two versions of DMD seems to be to work around old compiler issues.
Nowadays, DMD 2.079.0 is old enough (released 2018-03-01)
that it can be set as the mainline.
Finally, instead of used fixed locations that are dependent on the developer's setup,
simply use the DMD that should be in the PATH.

@Geod24
Copy link
Contributor Author

Geod24 commented Mar 14, 2021

Ping @WalterBright : This is fairly simple.

@Geod24
Copy link
Contributor Author

Geod24 commented May 11, 2021

Ping @WalterBright

@WalterBright
Copy link
Contributor

I use different compilers all the time To avoid annoying surprises, and to know what is being used, I hard code them in the makefile.

I tried changing the build compiler to 2.092, and sure enough it builds an executable that doesn't work:

Fatal error: more than 32767 symbols in object file

Don't know why at the moment.

@WalterBright
Copy link
Contributor

Something has gone wrong with compiling insidx in cgobj.d

@WalterBright
Copy link
Contributor

Ok, the problem with the 2.092 code generation is fixed. dlang/dmd#12515

But a new problem has cropped up. I use my Windows XP machine to run the DMC test suite, but dmd 2.092 no longer works on Windows XP, the system says it is not a valid EXE file.

https://issues.dlang.org/show_bug.cgi?id=21915

So, changing the makefile to use the latest compiler doesn't work.

The usage of two versions of DMD seems to be to work around old compiler issues.
Nowadays, DMD 2.079.0 is old enough (released 2018-03-01)
that it can be set as the mainline.
Finally, instead of used fixed locations that are dependent on the developer's setup,
simply use the DMD that should be in the PATH.
@Geod24
Copy link
Contributor Author

Geod24 commented May 31, 2021

@WalterBright : The next release will contain the fix. Plus, nothing prevents you from using make DMD=e:\dmd2.079. Can we get this in so I can rebase the CI PR ?

@Geod24
Copy link
Contributor Author

Geod24 commented Jun 21, 2021

Ping @WalterBright

@WalterBright
Copy link
Contributor

I've gotten everything to work with 2.092, so it's fine.

@WalterBright WalterBright merged commit 6b9798e into DigitalMars:master Jun 21, 2021
@Geod24 Geod24 deleted the dmd-from-path branch June 21, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants