Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beans with ':' in the name don't report correctly #90

Closed
ghost opened this issue Apr 5, 2016 · 0 comments · Fixed by #95
Closed

Beans with ':' in the name don't report correctly #90

ghost opened this issue Apr 5, 2016 · 0 comments · Fixed by #95
Milestone
0.11.0

Comments

@ghost
Copy link

ghost commented Apr 5, 2016

Already have a fix for this. Will submit pull request in a minute.
@ghost ghost mentioned this issue Apr 5, 2016
Closed
@yannmh yannmh added this to the 0.11.0 milestone Apr 26, 2016
yannmh pushed a commit that referenced this issue Apr 27, 2016
@yannmh
Fix for issue #90. Beans with ':' in the name should work correctly now.
0309099 
[yann@datadoghq.com] rebase on `master` to fix tests
@yannmh yannmh mentioned this issue Apr 27, 2016
Merged
yannmh added a commit to DataDog/dd-agent that referenced this issue May 13, 2016
@yannmh
[jmxfetch] update to 0.11.0
f5e7c81 
**Changes**
* [BUGFIX] Report properly beans with ':' in the name. See [#90][],
* [#91][], [#95][] (Thanks [@Bluestix][])
* [BUGFIX] Sanitize metric names and tags, i.e. remove illegal
* characters. See [#89][]
* [BUGFIX] Support `javax.management.Attribute` attribute types. See
* [#92][] (Thanks [@nwillems][])
* [FEATURE] Add user tags to service checks. See [#96][]
* [FEATURE] Allow group name substitutions in attribute/alias
* parameters. See [#94][], [#97][] (Thanks [@alz][])

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#89]: DataDog/jmxfetch#89
[#90]: DataDog/jmxfetch#90
[#91]: DataDog/jmxfetch#91
[#92]: DataDog/jmxfetch#92
[#94]: DataDog/jmxfetch#94
[#95]: DataDog/jmxfetch#95
[#96]: DataDog/jmxfetch#96
[#97]: DataDog/jmxfetch#97
[@alz]: /~https://github.com/alz
[@Bluestix]: /~https://github.com/bluestix
[@nwillems]: /~https://github.com/nwillems
yannmh added a commit to DataDog/dd-agent that referenced this issue May 13, 2016
@yannmh
[jmxfetch] update to 0.11.0
9c9a977 
**Changes**
* [BUGFIX] Report properly beans with ':' in the name. See [#90][],
* [#91][], [#95][] (Thanks [@Bluestix][])
* [BUGFIX] Sanitize metric names and tags, i.e. remove illegal
* characters. See [#89][]
* [BUGFIX] Support `javax.management.Attribute` attribute types. See
* [#92][] (Thanks [@nwillems][])
* [FEATURE] Add user tags to service checks. See [#96][]
* [FEATURE] Allow group name substitutions in attribute/alias
* parameters. See [#94][], [#97][] (Thanks [@alz][])

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#89]: DataDog/jmxfetch#89
[#90]: DataDog/jmxfetch#90
[#91]: DataDog/jmxfetch#91
[#92]: DataDog/jmxfetch#92
[#94]: DataDog/jmxfetch#94
[#95]: DataDog/jmxfetch#95
[#96]: DataDog/jmxfetch#96
[#97]: DataDog/jmxfetch#97
[@alz]: /~https://github.com/alz
[@Bluestix]: /~https://github.com/bluestix
[@nwillems]: /~https://github.com/nwillems
@yannmh yannmh mentioned this issue May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Fix bean names with ':' in the name DataDog/jmxfetch
1 participant
@yannmh