Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backgroundTasksEnabled ObjC API #2148

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add backgroundTasksEnabled ObjC API #2148

merged 1 commit into from
Dec 16, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Dec 16, 2024 •
edited
Loading

What and why?

This PR adds missing backgroundTasksEnabled ObjC API to the Datadog configuration.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@0xnm 0xnm requested review from a team as code owners December 16, 2024 11:23
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: nogorodnikov/add-background-tasks-enabled-configuration-to-objc-api
Commit report: a52fc99
Test service: dd-sdk-ios

✅ 0 Failed, 3583 Passed, 0 Skipped, 2m 31.25s Total Time
🔻 Test Sessions change in coverage: 2 decreased, 6 increased, 6 no change

🔻 Code Coverage Decreases vs Default Branch (2)

  • test DatadogCoreTests tvOS 78.48% (-0.09%) - Details
  • test DatadogSessionReplayTests iOS 34.24% (-0.02%) - Details

@0xnm
Copy link
Member Author

0xnm commented Dec 16, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 16, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-16 11:49:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in develop is 28m.

2024-12-16 12:06:36 UTC ❌ MergeQueue: The build pipeline failed for this merge request

Build pipeline has failing jobs for dfc7b6a:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@0xnm
Copy link
Member Author

0xnm commented Dec 16, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 16, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-16 12:15:09 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in develop is 28m.

2024-12-16 12:30:51 UTC ❌ MergeQueue: The build pipeline failed for this merge request

Build pipeline has failing jobs for 2671d35:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@0xnm 0xnm merged commit 108a87c into develop Dec 16, 2024
16 of 17 checks passed
@mariedm mariedm deleted the nogorodnikov/add-background-tasks-enabled-configuration-to-objc-api branch December 17, 2024 10:25
@maciejburda maciejburda mentioned this pull request Jan 2, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees
No one assigned
Labels
mergequeue-status: rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xnm @maciejburda