RUMM-2342 Add support to v2 request #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpelliard
reviewed
Jul 19, 2022
...k-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/internal/OkHttpUploader.kt
Outdated
Show resolved
Hide resolved
0xnm
approved these changes
Jul 20, 2022
| @@ -30,6 +36,7 @@ internal class OkHttpUploader : Uploader { | |||
| .Builder() | |||
| .callTimeout(NETWORK_TIMEOUT_MS, TimeUnit.MILLISECONDS) | |||
There was a problem hiding this comment.
it seems call timeout already includes time for both write and connect stages, so shouldn't we either keep only call timeout, or remove it and use a set of connect, write, read timeouts (read timeout probably doesn't matter)?
rpelliard
reviewed
Jul 20, 2022
...k-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/internal/OkHttpUploader.kt
Show resolved
Hide resolved
xgouchet
force-pushed
the
xgouchet/RUMM-2342/support_v2_api
branch
from
95c7ef4 to
2822016
Compare
xgouchet
force-pushed
the
xgouchet/RUMM-2342/support_v2_api
branch
from
2822016 to
a411dd9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #99 +/- ##
=============================================
- Coverage 89.96% 89.44% -0.52%
+ Complexity 147 146 -1
=============================================
Files 20 20
Lines 448 464 +16
Branches 50 52 +2
=============================================
+ Hits 403 415 +12
- Misses 28 30 +2
- Partials 17 19 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adapt the payload format to API v2
Motivation
Stay compatible with the backend processor evolutions