Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2271: Add files under kotlin source set to the repository information #212

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 29, 2023

What does this PR do?

AGP 7.0.0 introduced the additional kotlinDirectories to explicitly separate kotlin and java source sets, so if all the files are under kotlin, we were missing it. This PR fixes that.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 29, 2023 10:27
xgouchet
xgouchet previously approved these changes Nov 29, 2023
@0xnm 0xnm force-pushed the nogorodnikov/rum-1822/inject-build-id-into-source-map-upload branch from 789aafe to 6faaf0e Compare November 29, 2023 12:20
@0xnm 0xnm force-pushed the nogorodnikov/rum-2271/files-under-kotlin-source-set-are-not-added-to-repository-information branch 2 times, most recently from 0577c9f to 68132e4 Compare November 29, 2023 17:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Merging #212 (1537f56) into develop (0fd0071) will decrease coverage by 0.97%.
The diff coverage is 28.57%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #212      +/-   ##
=============================================
- Coverage      79.05%   78.08%   -0.97%     
- Complexity       186      187       +1     
=============================================
  Files             22       22              
  Lines            654      666      +12     
  Branches          81       85       +4     
=============================================
+ Hits             517      520       +3     
- Misses           107      117      +10     
+ Partials          30       29       -1     
Files Coverage Δ
...og/gradle/plugin/internal/GitRepositoryDetector.kt 97.06% <100.00%> (ø)
...n/com/datadog/gradle/plugin/internal/ProjectExt.kt 100.00% <ø> (ø)
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 54.65% <23.08%> (-2.22%) ⬇️

@0xnm 0xnm force-pushed the nogorodnikov/rum-1822/inject-build-id-into-source-map-upload branch 2 times, most recently from 9457ea3 to c4ace3b Compare December 8, 2023 12:07
Base automatically changed from nogorodnikov/rum-1822/inject-build-id-into-source-map-upload to develop December 8, 2023 12:54
@0xnm 0xnm dismissed xgouchet’s stale review December 8, 2023 12:54

The base branch was changed.

@0xnm 0xnm force-pushed the nogorodnikov/rum-2271/files-under-kotlin-source-set-are-not-added-to-repository-information branch from 68132e4 to 1537f56 Compare December 8, 2023 13:03
@0xnm 0xnm requested a review from xgouchet December 8, 2023 13:03
@0xnm 0xnm merged commit ee172eb into develop Dec 8, 2023
3 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-2271/files-under-kotlin-source-set-are-not-added-to-repository-information branch December 8, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants