Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIREL-2169: remove use of deprecated env variables #188

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jmfernandezalba
Copy link
Contributor

@jmfernandezalba jmfernandezalba commented Sep 7, 2023

What does this PR do?

Motivation

  • These variables will stop being valid after the upgrade to 16.0

Additional Notes

N/A

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jmfernandezalba jmfernandezalba requested a review from a team as a code owner September 7, 2023 14:18
0xnm
0xnm previously approved these changes Sep 7, 2023
mariusc83
mariusc83 previously approved these changes Sep 7, 2023
* The deprecated environment variables are changed according to [the official docs](https://docs.gitlab.com/ee/update/deprecations.html?removal_milestone=16.0#ci_build_-predefined-variables)
* These variables will stop being valid after the upgrade to 16.0
@jmfernandezalba
Copy link
Contributor Author

Sorry, I changed some variables that were actually used in codeship, not Gitlab. Please review again

@0xnm
Copy link
Member

0xnm commented Oct 4, 2023

@jmfernandezalba Are you able to merge this PR or you don't have enough rights and we should do that?

@0xnm 0xnm merged commit bfff839 into DataDog:develop Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants