RUMM-3487: Update AGP to 8.1.0 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rumm-3386/update-agp-to-8.1.0
branch
from
09538d9 to
e6d9cb1
Compare
0xnm
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #182 +/- ##
==========================================
Coverage 86.63% 86.63%
Complexity 178 178
==========================================
Files 21 21
Lines 576 576
Branches 72 72
==========================================
Hits 499 499
Misses 49 49
Partials 28 28 |
0xnm
force-pushed
the
nogorodnikov/rumm-3386/update-agp-to-8.1.0
branch
from
e6d9cb1 to
37902cf
Compare
mariusc83
reviewed
Jul 28, 2023
| @@ -81,7 +82,10 @@ internal class DdAndroidGradlePluginFunctionalTest { | |||
| libModulePlaceholderFile = File(libModuleKotlinSourcesDir, "Placeholder.kt") | |||
| datadogCiFile = File(testProjectDir.parent, "datadog-ci.json") | |||
|
|
|||
| stubFile(settingsFile, SETTINGS_FILE_CONTENT) | |||
| // we need to check that our plugin supports different AGP versions (backward and forward | |||
There was a problem hiding this comment.
don't you need a test for each better ?
mariusc83
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does update of
Gradle version to 8.2.1(removed from PR, see bug https://youtrack.jetbrains.com/issue/KT-60748) and also updates AGP version to 8.1.0.Review checklist (to be filled by reviewers)