Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-3398 Improve output of gradle plugin upload #173

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Jul 4, 2023

What does this PR do?

Ensure the message about upload "success" is always visible when running the upload task

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@xgouchet xgouchet requested a review from a team as a code owner July 4, 2023 09:26
@xgouchet xgouchet force-pushed the xgouchet/RUMM-3398/improve_logs branch from 6e89190 to 94c11c0 Compare July 4, 2023 12:48
@xgouchet xgouchet force-pushed the xgouchet/RUMM-3398/improve_logs branch from 94c11c0 to 3e3b7f9 Compare July 4, 2023 16:24
@codecov-commenter
Copy link

Codecov Report

Merging #173 (3e3b7f9) into develop (df43aad) will not change coverage.
The diff coverage is 77.78%.

@@            Coverage Diff             @@
##             develop     #173   +/-   ##
==========================================
  Coverage      86.63%   86.63%           
  Complexity       177      177           
==========================================
  Files             21       21           
  Lines            576      576           
  Branches          72       72           
==========================================
  Hits             499      499           
  Misses            49       49           
  Partials          28       28           
Impacted Files Coverage Δ
...m/datadog/gradle/plugin/internal/OkHttpUploader.kt 84.03% <66.67%> (ø)
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 74.36% <100.00%> (ø)
...in/com/datadog/gradle/plugin/DdCheckSdkDepsTask.kt 88.89% <100.00%> (ø)
.../datadog/gradle/plugin/internal/DdAppIdentifier.kt 100.00% <100.00%> (ø)

@xgouchet xgouchet merged commit db6dc21 into develop Jul 5, 2023
@xgouchet xgouchet deleted the xgouchet/RUMM-3398/improve_logs branch July 5, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants