Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2163: Disable dependencies check task by default #102

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 22, 2022

What does this PR do?

This change disables SDK check in the dependencies by default, to avoid false positive errors in certain setups.

We will come back to this check later in RUMM-2344.

Temporarily fixes #85.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 22, 2022 09:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #102 (33f9db2) into develop (8dc5f69) will decrease coverage by 2.13%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             develop     #102      +/-   ##
=============================================
- Coverage      89.44%   87.31%   -2.13%     
+ Complexity       146      145       -1     
=============================================
  Files             20       20              
  Lines            464      465       +1     
  Branches          52       53       +1     
=============================================
- Hits             415      406       -9     
- Misses            30       40      +10     
  Partials          19       19              
Impacted Files Coverage Δ
.../datadog/gradle/plugin/DdExtensionConfiguration.kt 100.00% <ø> (ø)
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 72.28% <50.00%> (-9.72%) ⬇️
...in/kotlin/com/datadog/gradle/plugin/DatadogSite.kt 80.00% <0.00%> (ø)

@0xnm 0xnm merged commit 869b928 into develop Aug 22, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2163/disable-dependencies-check-task-by-default branch August 22, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transitive dependency causes checkSdkDeps task to fail
4 participants