HAMR-164: Add migrate command #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-richey
commented
Sep 27, 2024
| @@ -94,7 +94,7 @@ def click_config_file_provider(ctx: Context, opts: CustomOptionClass, value: Non | |||
| type=int, | |||
| default=60, | |||
| show_default=True, | |||
| help="The HTTP request retry timeout period. Defaults to 60s", | |||
| help="The HTTP request retry timeout period in seconds.", | |||
There was a problem hiding this comment.
the show_default=True already shows the default of 60.
michael-richey
commented
Sep 27, 2024
| @@ -104,7 +104,7 @@ def click_config_file_provider(ctx: Context, opts: CustomOptionClass, value: Non | |||
| type=int, | |||
| default=30, | |||
| show_default=True, | |||
| help="The HTTP request timeout period. Defaults to 30s", | |||
| help="The HTTP request timeout period in seconds.", | |||
There was a problem hiding this comment.
the show_default=True already shows the default of 30.
heyronhay
approved these changes
Sep 27, 2024
| "--create-global-downtime", | ||
| required=False, | ||
| is_flag=True, | ||
| default=False, |
There was a problem hiding this comment.
we should probably switch the create-global-downtime to default to true since we almost always want it to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
migratecommand that both imports and sync resources in one step.Description of the Change
Add the
migratecommand that just does animportand async. Renamed the non_import_common_options to be diff_common_options since these options are shared between diff, sync, and migrate. Created sync_common_options to be shared between sync and migrate.