Adding a DevMode to the client #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new mode will send more telemetry metrics allowing users to more easily troubleshoot issues and usage of the client.
hush-hush
force-pushed
the
maxime/add-def-mode
branch
from
83f9ad9 to
ff410a4
Compare
hush-hush
force-pushed
the
maxime/add-def-mode
branch
from
ff410a4 to
93325c5
Compare
Those function should not have been public in the first place and there signature should not be part of the public API we support. Users shouldn't have any reason to use them as they can control everything through the client options.
hush-hush
force-pushed
the
maxime/add-def-mode
branch
from
93325c5 to
d78d533
Compare
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do
Adding a
DevModeto the client.The new mode will send more telemetry metrics allowing users to more easily troubleshoot issues and usage of the client.
Also, this makes the telemetry creator functions private. Those function should not have been public in the first place and there signature should not be part of the public API we support. Users shouldn't have any reason to use them as they can control everything through the client options.