Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Experiment and Filter components #9

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Added Experiment and Filter components #9

merged 2 commits into from
Sep 8, 2021

Conversation

krischarbonneau
Copy link
Contributor

@krischarbonneau krischarbonneau commented Sep 7, 2021 •
edited
Loading

Description

In this PR:

  • I've added the Experiment component and modified it's stories file to show both internal and external links
  • I've added the public directory as necessary for the external link SVG and updated the run storybook script to search for static content in the public directory when starting
  • I've added the Filter component
  • I've updated the tailwind config to include the custom-blue-projects-link color

Steps to test

  1. Pull in branch
  2. Type npm i then npm run storybook
  3. Navigate through each component to confirm each work as they should

Checklist

  • Tests are included

Trello Board

https://trello.com/c/eEMzchij

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Storybooks Link For Branch
https://dts-stn.github.io/DECD-Design-System/refs/pull/9/merge

var-kyle
var-kyle approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@var-kyle var-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@var-kyle var-kyle merged commit 6814a23 into master Sep 8, 2021
@var-kyle var-kyle deleted the kris-experiment-filter branch September 8, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@var-kyle var-kyle var-kyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krischarbonneau @var-kyle