Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outertune doesn't support multiple timestamps on one line, app crashes infinitely because of it #143

Closed
4 tasks done
t3ddy-official opened this issue Dec 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@t3ddy-official
Copy link

Checklist

  • I am able to reproduce the bug with the latest debug version.
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

  1. Go to any song
  2. Paste in lyrics with multiple timestamps for one line
  3. Click save

Expected behavior

If the feature is implemented, show the lyrics correctly. If it isn't, don't show the lyrics or pop up an error

Actual behavior

App crashes and you cannot get it to boot up again unless you clear data from it

Screenshots/Screen recordings

I have no recordings

Logs

I don't think you need them for this but will provide if needed later

OuterTune version

0.6.3

Device & Android version

Redmi Note 9S, Android 14

Additional information

Multiple timestamps on one line literally means that you have multiple timestamps on one line, and that line will get played at all the timestamps during the song. This is great when you don't wanna rewrite the line over and over again. Here's how it looks:

[00:02.15][00:04.52][00:08.19] lol
[00:03.05] example

this would be the same thing as this

[00:02.15] lol
[00:03.05] example
[00:04.52] lol
[00:08.19] lol

@t3ddy-official t3ddy-official added the bug Something isn't working label Dec 18, 2024
@mikooomich
Copy link
Collaborator

mikooomich commented Dec 18, 2024

Can reproduce. Though, if you disable multiline lyrics, it shouldn't crash (and have what you're looking for)

reocat pushed a commit to reocat/OuterTune that referenced this issue Jan 2, 2025
* Gramophone parser doesn't support this well. It may interfere with word by word (Extended LRC) but its not like many have that anyways...
* Fixes DD3Boh#143

compressed LRC:
[00:02.15][00:04.52][00:08.19] lol
[00:03.05] example

this would be the same thing as this
[00:02.15] lol
[00:03.05] example
[00:04.52] lol
[00:08.19] lol
reocat pushed a commit to reocat/OuterTune that referenced this issue Jan 6, 2025
* Gramophone parser doesn't support this well. It may interfere with word by word (Extended LRC) but its not like many have that anyways...
* Fixes DD3Boh#143

compressed LRC:
[00:02.15][00:04.52][00:08.19] lol
[00:03.05] example

this would be the same thing as this
[00:02.15] lol
[00:03.05] example
[00:04.52] lol
[00:08.19] lol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants