Remove physical variant and momentary_positions

[emcek]

• remove PhysicalVariant enum and usage of physical variant
• remove MomentaryPositions enum and usage of momentary_positions
• update unit tests
• clean up documentation
• Fix for issue [BUG] Ka-50 controls definitions limited_rotary make no sense #532

[jdahlblom]

@charliefoxtwo, at some point that archive should be removed or zipped.

[jdahlblom]

@emcek, C-101, NS430 and Module.lua still have the removed parameter in calls to Control:new.

[emcek]

@jdahlblom
1. Can't see where removed parameters are still present
2. Not sure why one test if failing, looks right to me

I do not have local lua dev env. running :/

I think I got it. Please review.

[jdahlblom]

@jdahlblom 1. Can't see where removed parameters are still present 2. Not sure why one test if failing, looks right to me

I do not have local lua dev env. running :/

I think I got it. Please review.

Yup, looks good. I generated the new JSON files. How do we get that into this PR? I don't know git that well. Can I push to this PR?

[jdahlblom]

Hmm I pushed to this PR but can't see the commit.

[charliefoxtwo]

Yeah none of the files in the archive folder need to be (nor should be) changed. @jdahlblom youre right, we should just remove it entirely - the new modules have been working just fine.

[jdahlblom]

Github is lagging, my commit will show up later.

[emcek]

Yeah none of the files in the archive folder need to be (nor should be) changed. @jdahlblom youre right, we should just remove it entirely - the new modules have been working just fine.

So, I will revert them, to be clean in separate PR.

[charliefoxtwo]

Looks great, thank you for doing this! Now to remove api_variant...