add modified rounding function used in M-2000C to Module #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --- @param decimal_places integer | ||
| --- @return number | ||
| function Module.round2(num, decimal_places) | ||
| return tonumber(string.format("%." .. (decimal_places or 0) .. "f", num)) or 0 |
There was a problem hiding this comment.
I haven't looked into it, but there must be a more efficient way to round than converting a value to a string and then back to a number again?
I suspect this is also a losing battle since some floats (like 0.3) basically can't be rounded
There was a problem hiding this comment.
Googling the subject it seems that lua has weak support for rounding. This was suggested as the common way to do it on Stackoverflow.
There was a problem hiding this comment.
There was a problem hiding this comment.
It's common, but not necessarily performant. At any rate, I suspect that my PR #392 should solve the problem at hand (and it's in the core set value code so it will apply to all controls).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.