Added Logger.lua module and removed old log function #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the most needed functions for logging, dumping tables etc.
| function ScriptPath() | ||
| local str = debug.getinfo(2, "S").source:sub(2) | ||
| return str:match("(.*/)") | ||
| end |
There was a problem hiding this comment.
It's best to end a file with a trailing newline. That way if someone else has to come in here later and make changes, it doesn't show that they were the last one to change this line.
There was a problem hiding this comment.
I always forget, yes you told me before. Maybe now it will stick.
| @@ -13,7 +14,6 @@ package.path = "./Scripts/DCS-BIOS/lib/modules/memory_map/?.lua;" .. package.pat | |||
|
|
|||
| -- global functions that haven't been refactored yet | |||
| BIOS = {} | |||
| function BIOS.log(str) end -- noop | |||
There was a problem hiding this comment.
I'm guessing you'll need to require lfs here. there's a mocked variant in the compile folder that should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the most needed functions for logging, dumping tables etc.