Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define variable step tumb #308

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Define variable step tumb #308

merged 2 commits into from
Oct 1, 2023

Conversation

jdahlblom
Copy link
Contributor

@jdahlblom jdahlblom commented Oct 1, 2023

This will add it to Module and unit tests. Needed for F5-E3-3.

@jdahlblom jdahlblom marked this pull request as ready for review October 1, 2023 15:08
@charliefoxtwo
Copy link
Member

If this is only used in the F5, I'd suggest just leaving it in the F5 file. I think there are one or two other modules that have custom controls defined in the module file.

I haven't been worrying about tests for these one-off controls. In the future I'd like to expand the aircraft tests to test the specific getters and these custom controls, but I think that's a lower priority right now.

@jdahlblom
Copy link
Contributor Author

This will add it to Module and unit tests.

If this is only used in the F5, I'd suggest just leaving it in the F5 file. I think there are one or two other modules that have custom controls defined in the module file.

I haven't been worrying about tests for these one-off controls. In the future I'd like to expand the aircraft tests to test the specific getters and these custom controls, but I think that's a lower priority right now.

IT is used in 5 modules.

@jdahlblom jdahlblom added this pull request to the merge queue Oct 1, 2023
Merged via the queue into DCS-Skunkworks:master with commit cadf9ba Oct 1, 2023
@jdahlblom jdahlblom deleted the defineVariableStepTumb branch October 2, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants