Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move old format plane lua files to new folder #307

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Move old format plane lua files to new folder #307

merged 3 commits into from
Oct 1, 2023

Conversation

jdahlblom
Copy link
Contributor

@jdahlblom jdahlblom commented Oct 1, 2023

Those who have so far been migrated. So that there will be no mix up between these.

Those who have so far been migrated.
@jdahlblom jdahlblom marked this pull request as ready for review October 1, 2023 13:27
@charliefoxtwo
Copy link
Member

Something to consider: we've been commenting lines out in BIOS.lua so that if there's an issue, we can just uncomment and revert to the old method.

I think moving these files is fine, but we should also update the commented-out paths in BIOS.lua so that users can still revert if necessary.

@jdahlblom
Copy link
Contributor Author

jdahlblom commented Oct 1, 2023

Something to consider: we've been commenting lines out in BIOS.lua so that if there's an issue, we can just uncomment and revert to the old method.

I think moving these files is fine, but we should also update the commented-out paths in BIOS.lua so that users can still revert if
necessary.

Something to consider: we've been commenting lines out in BIOS.lua so that if there's an issue, we can just uncomment and revert to the old method.

I think moving these files is fine, but we should also update the commented-out paths in BIOS.lua so that users can still revert if necessary.

The part to where they have been moved are above Scripts and with a symlink not available. Do we really need this?
At least they now where to place the file --dofile(lfs.writedir()..[[Scripts/DCS-BIOS/lib/MetadataEnd.lua]])

@jdahlblom jdahlblom added this pull request to the merge queue Oct 1, 2023
Merged via the queue into DCS-Skunkworks:master with commit 99ba64b Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants