Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Articles #805

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Updates Articles #805

merged 2 commits into from
Apr 9, 2024

Conversation

timurtripp
Copy link
Contributor

@timurtripp timurtripp commented Apr 8, 2024 •
edited
Loading

This update:

  • Removes margin at the top of articles with header image.
  • Moves header image caption to immediately below header image.
  • Removes options for black text or hiding the overlay on the header image, setting the white text on dark overlay as the default.
  • Updates description of the article header image text field.

Resolves #791
Resolves #790

Sister PR in: tiamat-custom-entities

@timurtripp timurtripp added bug Something isn't working change Modification to code without a functional change labels Apr 8, 2024
@timurtripp timurtripp requested a review from jcsparks April 8, 2024 16:26
@timurtripp timurtripp mentioned this pull request Apr 8, 2024
Merged
@timurtripp timurtripp added bug Something isn't working and removed bug Something isn't working labels Apr 8, 2024
@jcsparks jcsparks merged commit b715af8 into main Apr 9, 2024
2 checks passed
@jcsparks jcsparks deleted the issue/791 branch April 9, 2024 16:46
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
@jcsparks @web-flow
Merge pull request #805 from CuBoulder/issue/791
2784fb3 
Updates Articles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsparks jcsparks jcsparks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working change Modification to code without a functional change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with image header caption in articles Article header image display
2 participants
@timurtripp @jcsparks