Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Markdown linter #7

Closed
jcsparks opened this issue Sep 18, 2024 · 3 comments
Closed

Meta: Markdown linter #7

jcsparks opened this issue Sep 18, 2024 · 3 comments
Assignees
@timurtripp
Labels
change Modification to code without a functional change

Comments

@jcsparks
Copy link
Member

The Markdown linter we're using is throwing errors. Not sure if there's a newer version that runs better or if there's a configuration change that we need to make on this repo but would be nice for someone to dig in a bit and see if we can fix this linter config/settings rather than just ignoring the errors it's throwing for the changelog.md
@jcsparks jcsparks added the change Modification to code without a functional change label Sep 18, 2024
@timurtripp timurtripp self-assigned this Sep 18, 2024
@timurtripp
Copy link
Contributor

timurtripp commented Sep 27, 2024 •
edited
Loading

I think what this comes down to is, do we want to enforce certain Markdown rules for our pull requests, or do we want to just ignore the CHANGELOG.md entirely? I can look into if there's a way to automatically fix the existing errors and we'll probably have to make changes to the workflow to prevent new ones.

timurtripp referenced this issue in CuBoulder/tiamat-theme Sep 30, 2024
@timurtripp
CuBoulder/tiamat-theme#1308 Ignores CHANGELOG.md for linting
bf0a694
@timurtripp timurtripp transferred this issue from CuBoulder/tiamat-theme Oct 15, 2024
timurtripp added a commit to CuBoulder/tiamat-theme that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
8c1be85
timurtripp added a commit to CuBoulder/tiamat-theme that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
97aee95
timurtripp added a commit to CuBoulder/tiamat10-profile that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
e47a638
timurtripp added a commit to CuBoulder/tiamat10-project-template that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
d9053fd
timurtripp added a commit to CuBoulder/ucb_site_configuration that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
028c456
timurtripp added a commit to CuBoulder/ucb_admin_menus that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
b3f06ba
timurtripp added a commit to CuBoulder/tiamat-custom-entities that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
bfb1e1d
timurtripp added a commit to CuBoulder/ucb_default_content that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
9ae4046
timurtripp added a commit to CuBoulder/ucb_bootstrap_layouts that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
4eee664
timurtripp added a commit to CuBoulder/ucb_ckeditor_plugins that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
d45af7c
timurtripp added a commit to CuBoulder/ucb_styled_block that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
88773f8
timurtripp added a commit to CuBoulder/ucb_campus_news that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
dce3fce
timurtripp added a commit to CuBoulder/express_admin that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
408320e
timurtripp added a commit to CuBoulder/ucb_user_invite that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
a042ca6
timurtripp added a commit to CuBoulder/ucb_focal_image_enable that referenced this issue Oct 15, 2024
@timurtripp
CuBoulder/action-collection#7 Updates linter workflow
58b01bd
This was referenced Oct 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 15, 2024
Merged
Merged
Merged
Merged
@jcsparks
Copy link
Member Author

I think I got them all merged in, let me know if I missed any.

@timurtripp
Copy link
Contributor

Looks good, I'll mark this as resolved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timurtripp timurtripp

Labels
change Modification to code without a functional change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcsparks @timurtripp