Benchmark Wasm via argon2 and change gas price to 150_000 per op #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
benchmark_argon2
branch
from
145fd63 to
5cbaf45
Compare
webmaster128
force-pushed
the
benchmark_argon2
branch
from
5cbaf45 to
40a9e6a
Compare
webmaster128
changed the title
webmaster128
requested review from
maurolacy and
ethanfrey
and removed request for
maurolacy
ethanfrey
approved these changes
Sep 29, 2021
| millisecond. This idea is [inspired by NEAR][neargas] and we encourage you to | ||
| read their excellent docs on that topic. | ||
|
|
||
| In order to meet this target, we execute Argon2 in a test contract ([#1120]). |
There was a problem hiding this comment.
This is a great document.
The one question I raise is the reproduceability of "this consumed 96837752 gas and took 15ms on our CI system". They may upgrade the CI sometime.
It is fine for now, but we should have a better benchmark system sometime. (Can be in a few months)
| ed25519_batch_verify_one_pubkey_cost: GasConfig::calc_crypto_cost( | ||
| GasConfig::ED255219_BATCH_VERIFY_ONE_PUBKEY_FACTOR, | ||
| ), | ||
| // ~154 us in crypto benchmarks |
There was a problem hiding this comment.
This looks very sensible and coherent pricing now.
uint
approved these changes
Sep 29, 2021
maurolacy
approved these changes
Sep 30, 2021
Absolutely! Thank you for the hint. Will update. |
|
On reflection, this means that it is 150ns per wasm op? |
|
Oh, Terragas not Gigagas. Much nicer 😄 1 cosmwasm gas = 1 femtosecond of execution. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.