tests: rlpTxn tests #1800
Merged
tests: rlpTxn tests #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Closed
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
…cer into 1793-rlp_txn-testing
lorenzogentile404
requested changes
Feb 26, 2025
There was a problem hiding this comment.
There is still a TODO. Is it something to include in this PR? In general, could you add a short description of the purpose of the test or point to Java issue describing it? I just made the SEED non-static to avoid non-determinism in the case more tests are added in the same class in the future.
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
|
@lorenzogentile404 added doc. And yes, the TODO will remain, as I don't know how to solve it ATM |
lorenzogentile404
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.