bugfix: mount_option: handle commented lines

[maage]

Description:

From fstab(5):
...
Each filesystem is described on a separate line. Fields on each
line are separated by tabs or spaces. Lines starting with '#' are
comments. Blank lines are ignored.
...

Line like:

  # /var needs dev

should be ignored.

Add test for this issue.

Rationale:

It is feasible /etc/fstab contains commented out lines. It is not good if rules confuse commented out lines as real.

Review Hints:

There is a new test.

[openshift-ci]

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Mab879]

/ok-to-test

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[codeclimate]

Code Climate has analyzed commit ee5352b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

[vojtapolasek]

/ok-to-test

[vojtapolasek]

Hello @maage and thank you for this contribution. Actually you uncovered an interesting topic.
I created modificaion of your test, which inserts a correct line, comments it, and then inserts a bad line. I found out that Ansible remediation can handle that well, but the Bash remediation can't fix it.
Would you cover this case in this PR as well? Or should I create a separate upstream issue?
Other than that, the PR looks good.

[maage]

@vojtapolasek I guess another PR would suit me best.

[vojtapolasek]

Looks good. During review I discovered a problem in Bash remediation which incorrectly handles commented out correct lines. I will create an upstream issue for that case.