Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule package_mailx_installed #10495

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Apr 26, 2023

Description:

  • Created rule package_mailx_installed

Rationale:

  • This covers OL08-00-010358 & OL07-00-020028 STIG ids

Review Hints:

  • This uses a few well established templates, so automatus results should be enough to validate this.
  • This also applies to RHEL-08-010358 & RHEL-07-020028 so let me know if you want me to add it to RHEL profiles

@Xeicker Xeicker requested a review from a team as a code owner April 26, 2023 18:51
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link
Contributor

@freddieRv freddieRv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@marcusburghardt marcusburghardt added RHEL Red Hat Enterprise Linux product related. Oracle Linux Oracle Linux product related. STIG STIG Benchmark related. labels Apr 27, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone Apr 27, 2023
@marcusburghardt marcusburghardt added the New Rule Issues or pull requests related to new Rules. label Apr 27, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change.

Thanks for the PR!

Xeicker added 3 commits April 27, 2023 12:06
This covers OL08-00-010358 STIG id

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker force-pushed the OL08-00-010358_implementation branch from 902d48a to ee0f846 Compare April 27, 2023 18:10
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit ee0f846 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Apr 27, 2023

Waving the Automatus tests rule is not applicable for that test.

@Mab879 Mab879 merged commit 0c15999 into ComplianceAsCode:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Oracle Linux Oracle Linux product related. RHEL Red Hat Enterprise Linux product related. STIG STIG Benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants