Enable ensure_shadow_group_empty for RHEL7 #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusburghardt
added
RHEL7
|
Start a new ephemeral environment with changes proposed in this pull request: rhel7 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
Mab879
approved these changes
Apr 3, 2023
Mab879
requested changes
Apr 3, 2023
marcusburghardt
force-pushed
the
cis_ensure_shadow_group_empty
branch
from
1e4da19 to
38246a1
Compare
Done. Thanks |
|
Code Climate has analyzed commit 38246a1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4% (0.0% change). View more on Code Climate. |
|
Automatus CS8 and CS9 are expected to fail because this rule was enabled only for RHEL7. |
Mab879
added
the
Update Profile
Mab879
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
ensure_shadow_group_emptyrule satisfies the following CIS requirement for RHEL7:This rule was already removed from latest CIS versions for RHEL8 and RHEL9.
It is likely possible it will be also removed in RHEL7. In this context, it is not intended to include an Ansible remediation in this PR.
In any case, the requirement is still present in the current CIS version for RHEL7 and the respective control file was updated.
Rationale:
Better CIS coverage for RHEL7.