apparmor: apply only to platform machine #10303
Conversation
|
Hi @candrews. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: sle12 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffPlatform has been changed for rule 'xccdf_org.ssgproject.content_rule_package_pam_apparmor_installed'
--- xccdf_org.ssgproject.content_rule_package_pam_apparmor_installed
+++ xccdf_org.ssgproject.content_rule_package_pam_apparmor_installed
@@ -1 +1 @@
-cpe:/a:machine
+
Platform has been changed for rule 'xccdf_org.ssgproject.content_rule_apparmor_configured'
--- xccdf_org.ssgproject.content_rule_apparmor_configured
+++ xccdf_org.ssgproject.content_rule_apparmor_configured
@@ -1 +1 @@
-cpe:/a:machine
+ |
The 'Ensure AppArmor is installed' rule should not apply to containers. None of the apparmor rules should apply to containers, so set "machine: apparmor" for that group. Cleanup instances of "platform: machine" for rules in that group that already have this restriction to eliminate redundancy. Signed-off-by: Craig Andrews <candrews@integralblue.com>
candrews
changed the title
|
Code Climate has analyzed commit ff0df53 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
|
/restest |
|
@Mab879 could you take a look at the fedora test fail, I think that is expected and the testing-farm:centos seems unrelated right? |
|
/packit retest-failed |
|
Rerunning the Testing Farm test fixed the issue. The Automatus failures are expected as the rules are not applicable to the machines under test. |
thanks for checking it! |
Description:
apparmor: apply only to platform machine
The 'Ensure AppArmor is installed' rule should not apply to containers.
None of the apparmor rules should apply to containers, so set "machine: apparmor" for that group.
Cleanup instances of "platform: machine" for rules in that group that already have this restriction to eliminate redundancy.
Rationale:
AppArmor is a host technology and doesn't apply to or make sense within containers.
Review Hints:
With this change applied,
oscap-podman ubuntu:20.04 xccdf eval --report report.html --profile xccdf_org.ssgproject.content_profile_stig /usr/share/xml/scap/ssg/content/ssg-ubuntu2004-ds.xmlshould yield a report indicating that the "Ensure AppArmor is installed" rule is "Not Applicable"