Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop tweaks #389

Merged
merged 56 commits into from
Jul 6, 2023
Merged

Pop tweaks #389

merged 56 commits into from
Jul 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2023

Investors is urban version of landlord, which is rural equivalent
This means qualifications also should mirror it.

…as both of those are urban/rural upper strata instead of one being upgrade of other
@github-actions github-actions bot requested review from Arcadyi and DZappala July 2, 2023 08:47
raxo2222 added 3 commits July 2, 2023 13:50
…as WWII), and set start_quality_of_life to match starting expected SoL for strata.
… 99 sol) is 53%/95% from mixed/private healthcare
@ghost ghost changed the title qualification tweak Pop tweaks Jul 2, 2023
Comment on lines +67 to +75
if = {
limit = {
is_pop_type = investors
}
multiply = {
value = 3
desc = QUALIFICATIONS_FAVORED_TYPE
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah idk how I feel about investors being a preferred type for engineers. Most of the investors were meant to come from professionals since they represent the gilded class of workers that are more likely to move up a strata.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

investors and landlords are meant to be equivalent, why engineers would be more likely to be rural business owners rather than urban ones?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Professionals work in urban buildings, engineers work in industry and rural buildings. I think the distinction makes sense.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So:
Professionals <-> investors
Engineers <-> investors and landlords
Farmers <-> landlords
investors <-> landlords
That would be okay for favored types?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds good

@@ -7,7 +7,7 @@
111
}
strata = middle
start_quality_of_life = 8
start_quality_of_life = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clergy are meant to have a shittier QoL than someone working as an Academic, Engineer or Professional. Mostly bc being in the clergy doesn't really make you that much money.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_quality_of_life is only used for initialization, nothing else
Same with wealth effect scripts.
This means its effect is forgotten within first months of gameplay.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why, if its only used for initialization, does it need to move up to ten? What effect are you trying to achieve here?

Copy link
Author

@ghost ghost Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted all changes to start_quality_of_life - I thought it was completely unused, or at least only used in such niche situation, that you wouldn't even notice it.

@@ -7,7 +7,7 @@
169
}
strata = middle
start_quality_of_life = 8
start_quality_of_life = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creatives are amongst the poorest of the middle class barring Hollywood actors which we classify as "investors."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -6,7 +6,7 @@
117
}
strata = rich
start_quality_of_life = 20
start_quality_of_life = 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was 20 really to high?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -46,6 +46,8 @@
}
if = {
limit = {
is_pop_type = engineers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with professionals here, not so much with engineers for reasons stated above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well landlords used to be executives, and investors were meant to be more luxurious version of it.
Now its just rural/urban divide of upper class ownership.
So instead engineers shouldn't be more likely to become investors as well.

@@ -6,7 +6,7 @@
125
}
strata = rich
start_quality_of_life = 18
start_quality_of_life = 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A landlord should have worse QoL than an Investor.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't affect game once initialized, so same as above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sign was intended to be negative, as otherwise the tech was only negative effects

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, so its effect is meant to counter latest sol literacy increase
Maybe it should decrease mortality as well? Not by much, more like -0.01

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have plenty of mortality decrease techs IMO. There's a tech rework in the branches, so I'm not that worried about a tech being kinda lame, but it should still have at least some redeeming factor. In this case, that factor is reducing the sol literacy increase.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert change to tech then

common/scripted_effects/00_starting_pop_wealth.txt Outdated Show resolved Hide resolved
raxo2222 added 2 commits July 3, 2023 22:22
Here is relationship between upper and middle strata qualifications:
Professionals <-> investors
Engineers <-> investors and landlords
Farmers <-> landlords
investors <-> landlords
JackEPepper
JackEPepper previously approved these changes Jul 4, 2023
@DZappala DZappala enabled auto-merge July 6, 2023 18:08
@DZappala DZappala disabled auto-merge July 6, 2023 18:12
@DZappala DZappala enabled auto-merge July 6, 2023 18:12
@DZappala DZappala disabled auto-merge July 6, 2023 18:12
@DZappala DZappala enabled auto-merge July 6, 2023 18:12
@DZappala DZappala disabled auto-merge July 6, 2023 18:15
@DZappala DZappala enabled auto-merge July 6, 2023 18:15
auto-merge was automatically disabled July 6, 2023 18:15

Merge queue setting changed

@DZappala DZappala merged commit 0dcbbd1 into dev Jul 6, 2023
@DZappala DZappala deleted the qualification-tweak branch July 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants