Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pops 3.0 #314

Merged
merged 492 commits into from
Jun 15, 2023
Merged

Pops 3.0 #314

merged 492 commits into from
Jun 15, 2023

Conversation

JackEPepper
Copy link
Member

ITS HAPPENING .JPG

DZappala and others added 30 commits May 29, 2023 18:28
@DZappala
fix: tax law
b1281a1
@JackEPepper
feat: ai weights
4dd497c
@DZappala
fix: resolve various law errors
6ecec8c
@DZappala
Merge branch 'pops-3.0' of /~https://github.com/Cold-War-Project/CWP-Main…
0fab436 
… into pops-3.0
@JackEPepper
feat: more weights
2fb2466
chore: no need for that thing, as we have law with this name
2671e5f
@DZappala
chore: comment out old laws
56bbad5
Merge branch 'dev' into pops-3.0
2ac43b9
@DZappala
feat: update political setup schema to make more sense
72851af
@DZappala
feat: update senegal template (wip)
ede8332
fix: cleanup in law groups
cba5abc
chore: law loc from ground zero
37c7ae5
fix: lawgroup locs
cce4069
@DZappala
Merge branch 'master' of /~https://github.com/Cold-War-Project/CWP-Main …
59c7dfc 
…into draft/free-marco
@DZappala
fix: senegal starting laws fixed
88686e6
@DZappala
Merge branch 'draft/free-marco' of /~https://github.com/Cold-War-Projec…
4a4d61a 
…t/CWP-Main into pops-3.0
@DZappala
fix: senegal laws
813a079
fix: law locs
970a0bd
Merge branch 'pops-3.0' of /~https://github.com/Cold-War-Project/CWP-Main…
c979f46 
… into pops-3.0
chore: typos
d2ad577
fix: increased default starting workforce ratio to 0.3
de883d3
fix: monocle for landlords
17eeac6
fix: removed duplicates
8288313
chore: files must be bom format
9a3b082
@JackEPepper
chore: law number adjustments
2d862ff
@JackEPepper
chore: added ai enact weights
fa062e3
@JackEPepper
fix: fixes
2d72e85
@DZappala
feat: French and British colonial nations
9197dab
@DZappala
Merge branch 'pops-3.0' of /~https://github.com/Cold-War-Project/CWP-Main…
3347ca1 
… into pops-3.0
fix: loc for institutions
7f28ab3
@github-actions github-actions bot requested review from Arcadyi and DZappala June 14, 2023 22:19
@DZappala DZappala requested review from Max200012, a user and ademblon and removed request for DZappala June 14, 2023 22:46
@ademblon
Copy link
Contributor

This look pretty good, I've a lot of good things to say but it's probably not the place.

Here's what I consider critical, and must be changed before I approve :

  1. Mines production methods.

The mine should not employ engineer before colossal machinery at minima. Mines should be a low qualification job and you don't need to be an engineer to use basic electrical equipment.

  1. Biotech need tech restriction. I went from theoretical to unrestricted in go, in 57.
    Btw, shouldn't it go the other way around ? We sure didn't care about animals and humans life in the past

  2. lot of icon missing

  3. The institution ui needs to be fixed. If it's impossible to fix, then lower the max number of institution to 9. We can't release a mod looking like this, better rebalance now than in 6 months

@DZappala DZappala merged commit 51a4010 into dev Jun 15, 2023
@DZappala DZappala deleted the pops-3.0 branch June 15, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcadyi Arcadyi Arcadyi approved these changes

@Max200012 Max200012 Awaiting requested review from Max200012

@ademblon ademblon Awaiting requested review from ademblon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JackEPepper @ademblon @Arcadyi @DZappala @Max200012 @Mr-Jangoon