Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect design update #296

Merged
merged 6 commits into from
Jan 1, 2019
Merged

Conversation

rishichawda
Copy link
Contributor

@rishichawda rishichawda commented Dec 31, 2018

Status :

Ready

Description :

Minor design updates.
Bug fix.

Related Issues :

#287

Todos

  • Tests
  • Documentation

Copy link
Contributor

@kaushiknishchay kaushiknishchay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change the List Item Hover and selected Values color, Currently both are same.

Selected Values Chip:

  • add padding on the left of close icon

@rishichawda
Copy link
Contributor Author

@kaushiknishchay Updated the hover styles and chip icon. Also added animation on selecting an item.

@rishichawda rishichawda merged commit 23a7d1a into development Jan 1, 2019
@rishichawda rishichawda deleted the multiselect-design-update branch January 1, 2019 12:59
rishichawda added a commit to rishichawda/react-lite-ui that referenced this pull request Jan 1, 2019
…rahma#296)

* fix(multiselect): update option height and icon

Codebrahma#287

* fix(multiselect): fix chip design and update icon

* fix(multiselect): bug fix on selecting items

* refactor(multiselect): remove dead code

* fix(multiselect): update multiselect design

* fix(multiselect): update selected chip animation
@rishichawda
Copy link
Contributor Author

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants