Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card design update #290

Merged
merged 7 commits into from
Jan 3, 2019
Merged

Card design update #290

merged 7 commits into from
Jan 3, 2019

Conversation

rishichawda
Copy link
Contributor

@rishichawda rishichawda commented Dec 28, 2018

Status :

Ready

Description :

Update card component's design

Related Issues :

#287

Todos

  • Tests
  • Documentation

@rishichawda rishichawda changed the base branch from master to development December 28, 2018 12:32
@rishichawda rishichawda self-assigned this Dec 28, 2018
lib/card/theme.module.scss Outdated Show resolved Hide resolved
lib/card/index.js Outdated Show resolved Hide resolved
@rishichawda rishichawda added this to the v1.0.1 milestone Dec 31, 2018
lib/card/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@KRRISH96 KRRISH96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 minor changes and good to go.

Co-Authored-By: rishichawda <rishichawda@users.noreply.github.com>
KRRISH96 and others added 3 commits January 2, 2019 12:16
Co-Authored-By: rishichawda <rishichawda@users.noreply.github.com>
@rishichawda rishichawda merged commit 77c5014 into development Jan 3, 2019
@rishichawda rishichawda deleted the card-design-update branch January 3, 2019 07:32
@rishichawda
Copy link
Contributor Author

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants