Validate father in same case as child #3492
Conversation
There was a problem hiding this comment.
Looks good to me! Sometime soon it might be nice to start writing tests that check multiple validations? I think your tests should have covered for the case when a father is missing - If so, we do not want has failed the sex check as well but we want this PR's validation to give errors.
Not the best example since I think your unit tests are sufficient for it, but something to consider.
Good point! I'll add unit tests for this rule as well. Maybe we can hold off on integration tests until we have the entire tomte flow in place. |
|
No description provided.