[client-v2] Proxy support #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
approved these changes
Jul 28, 2024
| @@ -444,6 +450,12 @@ public Builder useNewImplementation(boolean useNewImplementation) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder setHttpCookiesEnabled(boolean enabled) { | |||
| //TODO: extract to settings string constants | |||
| this.configuration.put("client.http.cookies_enabled", String.valueOf(enabled)); | |||
There was a problem hiding this comment.
- sticky sessions
- some enterprise proxies like F5 that store routing information in cookies
There was a problem hiding this comment.
actually there may be opposite case when cookies should not be preserved to avoid sticky session when proxy behavior may not be changed.
| public HttpAPIClientHelper(Map<String, String> configuration) { | ||
| this.chConfiguration = configuration; | ||
| this.httpClient = createHttpClient(configuration, null); | ||
| this.httpClient = createHttpClient(); | ||
| this.baseRequestConfig = RequestConfig.custom() | ||
| .setConnectionRequestTimeout(1000, TimeUnit.MILLISECONDS) |
There was a problem hiding this comment.
Should it be configurable?
There was a problem hiding this comment.
Yes. Added more configuration parameters. Planning to add more later.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: