Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom_settings option and tidy up code #1059

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add custom_settings option and tidy up code #1059

merged 1 commit into from
Aug 31, 2022

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Aug 31, 2022 •
edited
Loading

  • BREAKING CHANGE: type of settings changed from Map<String, Object> to Map<String, Serializable>
  • Add Local/File protocol and enhance clickhouse-cli-client accordingly
  • Add convenient methods in ClickHouseOption to avoid unnecessary type conversions
  • Add custom_settings option
  • Better support of sepcial settings: query_id, session_id, session_check and session_timeout in ClickHouseRequest

@zhicwu zhicwu linked an issue Aug 31, 2022 that may be closed by this pull request
max_query_size URL parameter stopped working #1046
Closed
@zhicwu zhicwu merged commit e358f46 into ClickHouse:develop Aug 31, 2022
@zhicwu zhicwu mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_query_size URL parameter stopped working
1 participant
@zhicwu