Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Added bad addresses to getpeers RPC endpoint #715

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

dethos
Copy link
Contributor

@dethos dethos commented Nov 10, 2018

What current issue(s) does this address, or what feature is it adding?
This pull request completes the getpeers RPC functionality. At the time of the implementation, neo-python didn't track bad peers so it wasn't able to provide that information, since then that functionality was added so we must update the RPC method.

How did you solve this problem?
Added bad peers based on the DEAD_ADDRS list on the NodeLeader.

How did you make sure your solution works?
Updated the getpeers test

Are there any special changes in the code that we should be aware of?
No

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@dethos dethos force-pushed the update-getpeers-rpc branch from 9f0d4f6 to 5ea3fcb Compare November 10, 2018 00:22
@coveralls
Copy link

coveralls commented Nov 10, 2018

Coverage Status

Coverage increased (+0.006%) to 83.02% when pulling 5ea3fcb on dethos:update-getpeers-rpc into f8c03ba on CityOfZion:development.

@jseagrave21
Copy link
Contributor

Nice!

@ixje
Copy link
Member

ixje commented Nov 14, 2018

Thanks!

@ixje ixje merged commit d6d662b into CityOfZion:development Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants