Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date string formatting to match the rest #7008

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

It was brought to my attention again in #7001 that the date format strings are a bit odd in places.

This change makes them consistent.

Screenshots (if appropriate)

Screenshot_20240507_085506

How to test the changes?

Visual inspection.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visual inspection.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner May 7, 2024 06:58
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 7, 2024 06:58
@DAcodedBEAT DAcodedBEAT added UI php Pull requests that update Php code labels May 7, 2024
@DAcodedBEAT DAcodedBEAT merged commit b345122 into ChurchCRM:master May 7, 2024
3 checks passed
@DAcodedBEAT DAcodedBEAT added this to the Current (5.8.0) milestone May 7, 2024
@respencer respencer deleted the fix-mismatched-date-formatting-continued branch May 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants