Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default Zip Code #6956

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

Adds support for a default Zip Code.

Resolves #6951

Screenshots (if appropriate)

Screen Shot 2024-04-23 at 21 28 42

Screen Shot 2024-04-23 at 21 29 26

How to test the changes?

  • Check that the field is in /SystemSettings.php#PeopleSetup
  • Typed in a value & save
  • Go to /FamilyEditor.php & confirm that the field is pre-populated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Visual inspection.
  • Check that the field was in /SystemSettings.php
  • Typed in a value & saved
  • Checked that the value was saved in the DB.
  • Went to /FamilyEditor.php & confirmed that the field was pre-populated.

Changes applied and tested on live site.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner April 23, 2024 19:41
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team April 23, 2024 19:41
@DAcodedBEAT DAcodedBEAT added enhancement Feature: Users php Pull requests that update Php code labels Apr 23, 2024
@DawoudIO DawoudIO added this to the vNext (5.8.0) milestone Apr 23, 2024
@DawoudIO
Copy link
Contributor

Please note that you have to regen the locale files when you add new strings

@DawoudIO
Copy link
Contributor

tested and works
thank you

@DawoudIO DawoudIO merged commit da27702 into ChurchCRM:master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature: Users php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Default Zip Code
3 participants