Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale Cleanup #6929

Merged
merged 16 commits into from
Apr 6, 2024
Merged

Locale Cleanup #6929

merged 16 commits into from
Apr 6, 2024

Conversation

DawoudIO
Copy link
Contributor

@DawoudIO DawoudIO commented Apr 6, 2024

Description & Issue number it closes

Just random clean up while testing locales

Screenshots (if appropriate)

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DawoudIO DawoudIO added this to the 5.7.0 milestone Apr 6, 2024
@DawoudIO DawoudIO requested a review from a team as a code owner April 6, 2024 16:56
@DawoudIO DawoudIO requested review from grayeul, DAcodedBEAT and MrClever and removed request for a team April 6, 2024 16:56
@DawoudIO
Copy link
Contributor Author

DawoudIO commented Apr 6, 2024

image
image
image

@DawoudIO DawoudIO changed the title New Locales (Japanese 10%) Locale Cleanup Apr 6, 2024
@grayeul
Copy link
Contributor

grayeul commented Apr 6, 2024

I have manually reviewed the code changes here.

@DawoudIO
Copy link
Contributor Author

DawoudIO commented Apr 6, 2024

I have manually reviewed the code changes here.

Thanks, I'm making smaller PRs from this to ensure we are clear on what the code does

@DawoudIO DawoudIO merged commit f034bea into master Apr 6, 2024
4 checks passed
@DawoudIO DawoudIO deleted the locale/new-locales-4-2024 branch April 6, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants