Update composer Libs #6902
Update composer Libs #6902
Conversation
| @@ -46,28 +46,28 @@ | |||
| "ext-session": "*", | |||
| "ext-zip": "*", | |||
| "ext-zlib": "*", | |||
| "azuyalabs/yasumi": "^2.4.0", | |||
| "defuse/php-encryption": "^2.3.1", | |||
| "azuyalabs/yasumi": "^2.7.0", | |||
There was a problem hiding this comment.
updating composer.json is not enough to update dependencies. Is there an associated composer.lock update?
There was a problem hiding this comment.
actually, it looks like many of these are already updated in /~https://github.com/ChurchCRM/CRM/blob/master/src/composer.lock - this change shouldn't be necessary.
There was a problem hiding this comment.
correct as we use ^ to get the latest, this is to just keep it updated
There was a problem hiding this comment.
right, but this change doesn't actually have any composer lib updates since composer.lock isn't updated
There was a problem hiding this comment.
changes in the composer.json doesn't line up with the composer.lock
|
can we merge this if it is harmless it is good to know we have a new min version |
sure, though this really isn't providing anything different than what the repository already has |
DAcodedBEAT
force-pushed
the
php-composer-update
branch
from
771ddf0 to
1929cd8
Compare
| @@ -46,28 +46,28 @@ | |||
| "ext-session": "*", | |||
| "ext-zip": "*", | |||
| "ext-zlib": "*", | |||
| "azuyalabs/yasumi": "^2.4.0", | |||
| "defuse/php-encryption": "^2.3.1", | |||
| "azuyalabs/yasumi": "^2.7.0", | |||
There was a problem hiding this comment.
changes in the composer.json doesn't line up with the composer.lock
DawoudIO
requested review from
grayeul and
DAcodedBEAT
and removed request for
a team
|
ok updated and checked in the .lock file |
|
LGTM - except the branch is currently out of date (behind) and needs to be updated from latest master before merging. |
Description & Issue number it closes
Update composer packages to latest version