run alter commands only if able to run alter commands, ignore inserts if already inserted

[DAcodedBEAT]

Description & Issue number it closes

this should hopefully help in bad migration scenarios as seen in gitter earlier (see https://matrix.to/#/!xSsEgXcTcVSgRZMDNu:gitter.im/$tBVJrJndO9EGSj2Pw_VESpzFVEJk8bzUvqCE65sFHEY?via=gitter.im&via=matrix.org&via=llamarific.social for more context)

How to test the changes?

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[DAcodedBEAT]

@MrClever let me know what you think about this - hopefully this can help the next time someone has DB migration issues, where we can just ask someone to replay a migration script

[MrClever]

I like the approach and I think it should avoid most of the failed upgrade scenarios we've seen previously. Will have to wait and see. Nice work!

[DawoudIO]

ya when testing the upgrade this did not work, did you test the upgrade and if that worked, which db version did you test with. On my docker setup this did not work

[DawoudIO]

if this function is going to be useful, we should keep it and not recreate it over and over... or put it in a file that run pre and post each release where it is needed