convert tedious sql strings to safer orm operations #6779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAcodedBEAT
added
Security
Platform: Database
Code Smell
php
DAcodedBEAT
force-pushed
the
sql-strings-to-orm
branch
2 times, most recently
from
4f2e9fa to
932c39a
Compare
Merged
MrClever
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Tested on my dev machine (VM) and it seems to work fine. Would appreciate some additional confirmation before pulling the trigger :)
Edit: noticed the CI testing is failing on these two tests:
1) Admin People
Family Property List:
AssertionError: Timed out retrying after 60000ms: expected 'http://localhost/PropertyEditor.php?PropertyID=0&Type=f' to include 'PropertyList.php'
at Context.eval (webpack://churchcrm/./cypress/e2e/ui/admin/admin.people.spec.js:39:17)
2) Admin People
Person Property List:
AssertionError: Timed out retrying after 60000ms: expected 'http://localhost/PropertyEditor.php?PropertyID=0&Type=p' to include 'PropertyList.php'
at Context.eval (webpack://churchcrm/./cypress/e2e/ui/admin/admin.people.spec.js:52:17)
Not sure if this is a test failure (and we need to update the CI script) or code failure and we're introducing a new failure.
MrClever
reviewed
Dec 30, 2023
|
@MrClever Thanks for doing the once-over! this change is deprioritized until 5.4.1 is out. I just pushed this up so folks are aware and we avoid potentially duplicated efforts. |
DAcodedBEAT
force-pushed
the
sql-strings-to-orm
branch
from
54efd52 to
0df939c
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Issue number it closes
working on making the application safer by going through the ORM (which uses prepared statements) rather than manually crafting sql which could become insecure