Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ckeditor #6601

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Ckeditor #6601

merged 2 commits into from
Oct 31, 2023

Conversation

brianteeman
Copy link
Contributor

What does PR do? Any background context you want to provide?

This updates the version of ckeditor to ckeditor4 and locks it to release 4.22.1 which is the last opensource release of the ckeditor4 series. (reference https://www.npmjs.com/package/ckeditor4)

Note that ckeditor5 is a different beast altogether

The path in the release does noty change so this should be 100% bc

What Issues does it Close? Any the relevant tickets?

Closes

Screenshots (if appropriate)

Where should the reviewer start?

How should this be manually tested?

Questions:

  • Is there a related website / article to substantiate / explain this change?

    • Yes - Link:
    • No
  • Does the development wiki need an update?

    • Yes - Link:
    • No
  • Does the user documentation wiki need an update?

    • Yes - Link:
    • No
  • Does this add new dependencies?

    • Yes
    • No
  • Does this need to add new data to the demo database

    • Yes
    • No

This updates the version of ckeditor and locks it to 4.22.1 which is the last opensource release of the ckeditor4 series.

Note that ckeditor5 is a different beast altogether
@DawoudIO DawoudIO added this to the 5.0.5 milestone Oct 31, 2023
@DawoudIO DawoudIO merged commit 052418c into ChurchCRM:master Oct 31, 2023
@brianteeman brianteeman deleted the ckeditor branch October 31, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants