Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logs to upgrade flow to make it easier to triage errors #6589

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

DAcodedBEAT
Copy link
Contributor

What does PR do? Any background context you want to provide?

I tried to upgrade within app and things were failing so I figured I can provide more information to myself during the upgrade process

What Issues does it Close? Any the relevant tickets?

N/A

Screenshots (if appropriate)

N/A

Where should the reviewer start?

the diff

How should this be manually tested?

tail -f the logs and the run an upgrade. if things work, awesome. if they don't, you should have more information to point to why it doesn't work instead of a generic uncaught exception from php

Questions:

  • Is there a related website / article to substantiate / explain this change?

    • Yes - Link:
    • No
  • Does the development wiki need an update?

    • Yes - Link:
    • No
  • Does the user documentation wiki need an update?

    • Yes - Link:
    • No
  • Does this add new dependencies?

    • Yes
    • No
  • Does this need to add new data to the demo database

    • Yes
    • No

@DawoudIO DawoudIO self-requested a review October 29, 2023 23:50
@DawoudIO DawoudIO added this to the 5.0.5 milestone Oct 29, 2023
@DawoudIO
Copy link
Contributor

I was able to upgrade the system but there is lots of error and the UI looks bad :/ let us log a bug to fix the upgrade UI

@DawoudIO DawoudIO merged commit caaf3d4 into ChurchCRM:master Oct 30, 2023
@DAcodedBEAT DAcodedBEAT deleted the log-upgrade-more branch October 30, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants