Remove php 7 from scripts #6576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAcodedBEAT
requested review from
crossan007,
DawoudIO and
MrClever
as code owners
|
@DawoudIO this should be good to go |
|
Very nice, i think I'll disable that test that sometime fails until I have it 100% working Thanks for helping here, I'll make sure this runs on PR and Master next |
DAcodedBEAT
force-pushed
the
fix-docker
branch
from
e235109 to
2c536c4
Compare
DAcodedBEAT
changed the title
|
@DawoudIO this is still good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Tells docker-compose to wait for database before starting the web app.
Screenshots (if appropriate)
What Issues does it Close?
N/A
What are the relevant tickets?
N/A
Any background context you want to provide?
I was restarting and running tests and noticed the first few failed because the db wasn't ready yet. This should also help with #6573.
Where should the reviewer start?
the diff
How should this be manually tested?
N/A
How should the automated tests treat this?
regression, make sure things still work.
Questions:
Is there a related website / article to substantiate / explain this change?
Does the development wiki need an update?
Does the user documentation wiki need an update?
Does this add new dependencies?
Does this need to add new data to the demo database